-
Notifications
You must be signed in to change notification settings - Fork 347
feat: added app lifecycle page #5186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
added app life cycle page
Automatically optimized images using optipng and jpegoptim via GitHub Actions
|
Your Upsun Fixed environment has successfully deployed. 🚀 See the changed pages: Upsun Fixed docs |
tylers-username
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kemi-Elizabeth - proposed a change
adjusted table and added note
…b.com/platformsh/platformsh-docs into 5185-new-page-to-be-added-about-hooks
turned vale off
Addressed changes and adjusted content accordingly
| - `start` blocks traffic until the application is running. | ||
| - `post_start` blocks traffic until all warm-up tasks complete. | ||
|
|
||
| Non-blocking hooks, such as `pre_start`, run before traffic concerns and do not affect when an instance begins receiving requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically, the pre_start runs before the start, so if start blocks, then pre_start also does :/
|
Sorry for the late comment, but shouldn't this mention the deploy and post_deploy hooks, and how they relate to the start commands? |
Added more info as Florian suggested
…b.com/platformsh/platformsh-docs into 5185-new-page-to-be-added-about-hooks
Automatically optimized images using optipng and jpegoptim via GitHub Actions
Removed sentence starter for better readability
…b.com/platformsh/platformsh-docs into 5185-new-page-to-be-added-about-hooks
removed diagram
added new diagrams, changed text according to feedback from Florian
removed diagram
|
|
||
| {{< /note >}} | ||
|
|
||
| ## Web comannd use cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"comannd" should be "command"
|
|
||
| - `start` blocks traffic until the application is running. | ||
| - `post_start` blocks traffic until all warm-up tasks complete. | ||
| - `pre_start` is non-blocking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre_start is also blocking, I'd remove the whole distinction of non-blocking/blocking, they all block the deployment.
| | Command | When to use | Example task | | ||
| | -------------- | ---------------------------------------- | ------------------------------------------- | | ||
| | **pre_start** | Per-instance setup before app launch | Preparing local caches, setting permissions | | ||
| | **post_start** | Warm-up before instance receives traffic | Cache priming, loading dependencies | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typical example is rather "waiting for the application to be fully started"
Added app life cycle page (about hooks)
Why
Closes #5185
What's changed
New page has been added to Learn section about hooks and application lifecycle.
Where are changes
/learn/overview/app-life-cycle.html
Updates are for:
sites/platformtemplates)sites/upsuntemplates)